Code to replace the unexpected.tdb file

Stefan (metze) Metzmacher metze at samba.org
Wed Jan 5 05:41:57 MST 2011


Hi Volker,

> On Wed, Jan 05, 2011 at 01:05:11PM +0100, Stefan (metze) Metzmacher wrote:
>> I think this is wrong:
>> +       do {
>> +               sock = accept(server->listen_sock,
>> +                             (struct sockaddr *)(void *)&sunaddr, &len);
>> +       } while (sock == -1 && errno == EINTR);
>> +
>> +       if (sock == -1) {
>> +               return;
>> +       }
>>
>> when we got a signal we should return instead of looping,
>> so that signal events can be processed.
> 
> I had the same thought. But I've copied it from winbind, and
> it's pretty recent code by Andrew Bartlett. So I thought
> this would be right.

Ah, ok.

It seems that Andrew, just moved code around.
The loop is also present in 3.5.x.

I think we should fix that for 3.6.0.

metze

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 262 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20110105/0488d8f9/attachment.pgp>


More information about the samba-technical mailing list