[SCM] Samba Shared Repository - branch master updated

Jeremy Allison jra at samba.org
Mon Feb 28 14:56:13 MST 2011

On Mon, Feb 28, 2011 at 10:51:27PM +0100, Volker Lendecke wrote:

> Jeremy, I think this is the wrong fix. I have sent a patch
> to Tridge CC samba-technical that fixes it in a different
> way. Can you please coordinate with Tridge about the proper
> way to fix this? I did not push it directly with the big
> stream because this touches a core definition of tevent,
> which needs proper approval by Tridge.

Well I just fixed the warnings on a 64-bit box. It's not
a core change.

> Despite it might seem that I am neglecting my code, I'm
> trying my best to take care of it and get it into proper
> shape.
> What is your argument against my fix with the union? Is that
> not portable enough? Is it too much bloat?

I didn't see your message before my autobuild got sent :-).

That's the simple answer. I like your fix better. Please
feel free to revert and push yours instead :-).


More information about the samba-technical mailing list