[vlendec at samba.org: [SCM] Samba Shared Repository - branch master updated]

Volker Lendecke Volker.Lendecke at SerNet.DE
Mon Feb 28 09:50:09 MST 2011 

Hi, Tridge!

The attached patchset removes the use of select from Samba
with two exceptions. There are calls with NULL and empty
args that are essentially msleep equivalents. And there is
the tevent select and standard backends.

What shall we do about those? From my point of view the
tevent select backend should be removed. With the libreplace
poll implementation we get the same functionality. The
standard backend has the fallback to select, which seems
like some code duplication from the select and epoll
backends. A relatively easy but inefficient way would be to
set up the poll arrays in every tevent loop. Maintaining the
arrays in add_fd and del_fd is a bit hairier in the poll
than in the select fallback, so I would like to avoid the
code duplication. An alternative would be to use a similar
workaround and just ignore the high fd's.

With best regards,

Volker

----- Forwarded message from Volker Lendecke <vlendec at samba.org> -----

Date: Mon, 28 Feb 2011 17:27:02 +0100 (CET)
From: Volker Lendecke <vlendec at samba.org>
To: samba-cvs at samba.org
Subject: [SCM] Samba Shared Repository - branch master updated

The branch, master has been updated
       via  c1bc916 nsswitch: Eliminate select from wb_common
       via  d163f5d Remove sys_select[_intr]
       via  3254e39 tevent: Add a poll backend
       via  f7bd096 libcli: Eliminate select from smb_readline_replacement
       via  d825b5e s3: Eliminate select from libaddns
       via  5b26cfe s3: Eliminate sys_select from do_smb_resolve() -- untested
       via  b28a2e5 s3: Eliminate sys_select from do_smb_browse() -- untested
       via  89d81b3 s3: Eliminate sys_select_intr from smbfilter
       via  7eedf69 s3: Remove unused receive_packet
       via  a2970df s3: Eliminate sys_select_intr from read_fd_with_timeout
       via  e6f8208 s3: Eliminiate sys_select_intr from client.c
       via  884984a s3: Add poll_intr_one_fd
       via  83becbe s3: Add sys_poll_intr
       via  81bdaaf s3: Eliminate sys_select from g_lock_lock
       via  0f082de s3: Eliminate sys_select from fd_is_readable
       via  2b0057c s3: Eliminate select from packet_fd_read_sync
       via  deb58b2 s3: Add poll_one_fd()
       via  cf7d331 s3: Remove select-based s3 event backend
       via  ada2a5a s3: Use poll in nmbd
       via  c6c666a s3: Use poll in winbind
       via  9758afd s3: Use poll in smbd
       via  ea5e1c5 s3: Use poll for the event loop
       via  be33e2e s3: Add sys_poll
       via  0fc1650 libreplace: poll based on select
       via  5e93e3e s3: Add timeval_to_msec
      from  9bfbf65 s3:msg_idmap: The solaris cc compiler does not like unnamed unions as struct members - fix the build

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit c1bc916507d4afcf6763fc3ffa651e1ad3a8e931
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Feb 18 13:57:35 2011 +0100

    nsswitch: Eliminate select from wb_common
    
    Autobuild-User: Volker Lendecke <vlendec at samba.org>
    Autobuild-Date: Mon Feb 28 17:26:18 CET 2011 on sn-devel-104

commit d163f5d67cf461c77749a82b0f83138271ffe333
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Feb 18 12:34:08 2011 +0100

    Remove sys_select[_intr]

commit 3254e392208ac06c7cce3d89ca6369a224f7f481
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Feb 9 15:28:10 2011 +0100

    tevent: Add a poll backend

commit f7bd09665ae1dfed2a503314f4b4946fe0ee1bf5
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Feb 14 12:14:12 2011 +0100

    libcli: Eliminate select from smb_readline_replacement

commit d825b5e2cb960fdc348d068a7af3ffbd54cc1c3f
Author: Volker Lendecke <vl at samba.org>
Date:   Thu Feb 10 11:01:54 2011 +0100

    s3: Eliminate select from libaddns

commit 5b26cfe14395ce09461de9423bd745570702fd9e
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Feb 7 17:19:03 2011 +0100

    s3: Eliminate sys_select from do_smb_resolve() -- untested

commit b28a2e519a0f36da800b0fdab295c1875401ac84
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Feb 7 17:17:26 2011 +0100

    s3: Eliminate sys_select from do_smb_browse() -- untested

commit 89d81b310ec0f1bc7987f452eadc544403ee77ec
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Feb 9 13:38:06 2011 +0100

    s3: Eliminate sys_select_intr from smbfilter

commit 7eedf69bc9c9d2a5305f0c889e5f81139a537a29
Author: Stefan Metzmacher <metze at samba.org>
Date:   Fri Feb 18 12:32:12 2011 +0100

    s3: Remove unused receive_packet

commit a2970dfaef9ceac6af2784cbffe9e2d8ac14b188
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Feb 8 17:57:12 2011 +0100

    s3: Eliminate sys_select_intr from read_fd_with_timeout

commit e6f820835874e6bbf103768665952b7884cd8452
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Feb 8 17:56:10 2011 +0100

    s3: Eliminiate sys_select_intr from client.c

commit 884984ae0a9b551dcd92d6d0486b2d741eabd20f
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Feb 8 17:33:59 2011 +0100

    s3: Add poll_intr_one_fd

commit 83becbe369bcf3478063662fc2626ccbf4530b20
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Feb 8 17:28:27 2011 +0100

    s3: Add sys_poll_intr

commit 81bdaafab34995522fc9a7b16fcabf9cd09cb528
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Feb 8 11:59:04 2011 +0100

    s3: Eliminate sys_select from g_lock_lock

commit 0f082de561342b88ffd239b6cc3e11e059225380
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Feb 7 17:02:44 2011 +0100

    s3: Eliminate sys_select from fd_is_readable

commit 2b0057c2cb4f05005354008044049fc3dc2bd1fd
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Feb 7 16:59:38 2011 +0100

    s3: Eliminate select from packet_fd_read_sync

commit deb58b2e941f6d307f28f7b909f388c39fe915e8
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Feb 7 16:55:16 2011 +0100

    s3: Add poll_one_fd()

commit cf7d331511437cc0be7d2dfa9263da5658d96740
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Feb 7 15:24:07 2011 +0100

    s3: Remove select-based s3 event backend

commit ada2a5a2457ad0f91fc19e5de9391abbf059a93b
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Feb 7 15:20:39 2011 +0100

    s3: Use poll in nmbd

commit c6c666aa07760757d0491da6acf96c9b7794ec25
Author: Volker Lendecke <vl at samba.org>
Date:   Thu Feb 3 22:05:30 2011 +0100

    s3: Use poll in winbind

commit 9758afd47e12513c966aab7431dd674ce954cc59
Author: Volker Lendecke <vl at samba.org>
Date:   Thu Feb 3 21:55:02 2011 +0100

    s3: Use poll in smbd

commit ea5e1c5ecb7ab897a684bda88a49bb26fb557eb0
Author: Volker Lendecke <vl at samba.org>
Date:   Thu Feb 3 16:34:07 2011 +0100

    s3: Use poll for the event loop

commit be33e2e0a7b18c6d659d976afc507407904a69ed
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Feb 7 16:29:13 2011 +0100

    s3: Add sys_poll

commit 0fc1650e091727971b3e3017f9f06cae6cdf71bb
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Feb 9 19:22:25 2011 +0100

    libreplace: poll based on select

commit 5e93e3e88fb4a219492c23c18067f358b54311d0
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Feb 8 12:55:02 2011 +0100

    s3: Add timeval_to_msec

-----------------------------------------------------------------------

More information about the samba-technical mailing list