[patch] Make SMBTA store the IP Address of the client connection

[Holger Hetterich]

Am Montag, den 14.02.2011, 16:55 -0800 schrieb Jeremy Allison:
> On Sun, Feb 13, 2011 at 10:15:33PM +0100, Holger Hetterich wrote:
> > Reviewed patch attached, removing the
> > unneeded char *ip.
> > 
> > This patch applies to both master and v3-6-test.
> > 
> > Please commit if it's fine.
> > 
> > Holger
> > 
> > 
> > Am Sonntag, den 13.02.2011, 21:50 +0100 schrieb Holger Hetterich:
> > > Hi,
> > > 
> > > this patch adds the IP Address of the connecting client to the common
> > > data set of vfs_smb_traffic_analyzer.
> > > 
> > > Please review and commit if ok ;)
> > > 
> > > First attached patch is for the master branch.
> > > 
> > > I would like to see this in 3.6.0, so I've added a second patch against
> > > v3-6-test.
> 
> Does it handle IPv6 addresses ? I don't see that and it needs to.
> 

Hmm, I don't see it doesn't. When I connect from localhost it does
store ::1, when I connect using ipv6 from an other IPv6 machine, it
stores the clients ipv6 address, and when I connect from an IPv4
machine, it stores the IPv4 address, (all tests have been done with
smbclient). I have smbd logs proving this on my virtual machine. Or did
I miss any test regarding ipv6 in this case?

Holger



> Jeremy.

-- 
Holger Hetterich, hhetter at novell.com, 
  SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg)
   Maxfeldstr. 5, 90409 Nürnberg, Germany