Bug in samldb_description_check?

[Volker Lendecke]

On Mon, Feb 14, 2011 at 10:21:41AM +1100, tridge at samba.org wrote:
> After Andrew sent this message we found a much better solution. We now
> have a LDB_FLAG_INTERNAL_FORCE_SINGLE_VALUE_CHECK flag on
> elements. The samldb.c check on description now looks like this:
> 
> 	el = ldb_msg_find_element(ac->msg, "description");
> 	if (el != NULL) {
> 		el->flags |= LDB_FLAG_INTERNAL_FORCE_SINGLE_VALUE_CHECK;
> 	}
> 
> We've tested this, and constrained modifications on description now
> work. It is also much more efficient.
> 
> In general I'd like to keep subtle logic like single valued tests in
> one place. We already have it in the tdb backend, so the best approach
> is to have a way to enable that code for an element, instead of
> re-implementing it inside samldb.c. I think it would be worth keeping
> that in mind for some of the other subtleties that samldb.c handles
> now.
> 
> I've pushed the change to autobuild.

It seems it has not made it through autobuild. Any problems
with it?

Thanks,

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen