jlam at vixs.com
Fri Feb 11 16:35:10 MST 2011
I make a mistake, the data corruption is due to my change to the patch which let sys_sendfile() to call do_splice_from_socket() when appropriate. I think you should have this already, otherwise, the patch won't have any effect to sendfile(). Anyway, I attached in case you are interested.
Also, for the samba patch to lib/recvfile.c, I suggest to make the following change:
-#if defined(HAVE_SENDFILE) && defined(LINUX_SENDFILE_API)
+#if (defined(HAVE_SENDFILE64) || defined(HAVE_SENDFILE)) && defined(LINUX_SENDFILE_API)
> -----Original Message-----
> From: samba-technical-bounces at lists.samba.org [mailto:samba-technical-
> bounces at lists.samba.org] On Behalf Of Jacky Lam
> Sent: Friday, February 11, 2011 11:51 AM
> To: Jeremy Allison
> Cc: Volker.Lendecke at SerNet.DE; samba-technical at lists.samba.org
> Subject: RE: Zero-copy patch
> > -----Original Message-----
> > From: Jeremy Allison [mailto:jra at samba.org]
> > Sent: Friday, February 11, 2011 11:49 AM
> > To: Jacky Lam
> > Cc: Jeremy Allison; Volker.Lendecke at SerNet.DE; samba-
> > technical at lists.samba.org
> > Subject: Re: Zero-copy patch
> > On Thu, Feb 10, 2011 at 10:47:42PM -0500, Jacky Lam wrote:
> > > No change is source level. I just change the test platform from x86
> > to MIPS. Maybe my MIPS's throughput level is CPU power and this patch
> > helps that.
> > Ah ok - I misunderstood. That is indeed a great help !
> > Did you also look into the scheduler change I mentioned ?
> Yes, I change the scheduler but no change in throughput or CPU
> loading.....Any extra tuning of scheduler parameter needed?
> > > I am still investigating the problem and will send you the patch if
> > fix it.
> > Thanks - much appreciated !
> > Jeremy.
> IMPORTANT CONFIDENTIALITY NOTICE
> This message and any attached documents contain information from ViXS
> Systems, Inc. and are confidential and privileged and further subject
> to any confidentiality agreement between the parties. The information
> is intended to be viewed only by the individual(s) or entity(ies) to
> whom the message is addressed. If you are not the intended recipient,
> be aware that reading, disclosing, copying, distributing or using the
> contents of this transmission is prohibited. Please notify us
> immediately if you have received this transmission in error, and delete
> this message along with any attached files.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 4286 bytes
More information about the samba-technical