make test TESTS=acl.python fails

Matthias Dieter Wallnöfer mdw at samba.org
Fri Feb 11 08:36:09 MST 2011


Nadya,

well that we've typed it as "uint32_t" is a convention - it shouldn't 
change anything. If you would like to have it "signed" I would prefer to 
have it at least "int32_t" (to express that it has exactly this length).

Regards,
Matthias

Nadezhda Ivanova wrote:
> Hi Matthias,
> Kamen figured out what is the problem with the failing test, and we 
> will be pushing a fix shortly. The problem was acl module was 
> comparing with the wrong ndts guid value.
> As for your patch, given this: 
> http://msdn.microsoft.com/en-us/library/ms680832%28v=vs.85%29.aspx
> where it becomes clear that userAccountControl is a signed integer, 
> and actually we always do bitwise checks for flags on it rather than 
> integer comparison, I would rather we do not change to unsigned. Was 
> there any particular reason it is unsigned in samdb module?
>
> Regards,
> Nadya
> On Fri, Feb 11, 2011 at 4:22 PM, Matthias Dieter Wallnöfer 
> <mdw at samba.org <mailto:mdw at samba.org>> wrote:
>
>     Nadya,
>
>     could you also live with attached patch? This changes ACL module's
>     "userAccountControl" handling to match the one from the samldb LDB
>     module. Let us try out if this makes host "tridge" more happy.
>
>     Regards,
>     Matthias
>
>     Nadezhda Ivanova wrote:
>
>         Hi Matthias,
>         I am OK with the changes in create_descriptor.c, although I do
>         not think this is the cause of the problem as it is not
>         actually possible to have so many ACEs as to overflow these
>         counters, we would run out of memory before that. For the
>         other files ping Andrew Bartlett.
>
>         Regards,
>         Nadya
>
>         On Thu, Feb 10, 2011 at 11:26 AM, Matthias Dieter Wallnöfer
>         <mdw at samba.org <mailto:mdw at samba.org> <mailto:mdw at samba.org
>         <mailto:mdw at samba.org>>> wrote:
>
>            Nadya,
>
>            I've looked a bit over the libcli/security code and have
>         found the
>            following counter and format string errors. What do you say?
>
>            Matthias
>
>
>            Matthias Dieter Wallnöfer wrote:
>
>                Matthieu, Nadya,
>
>                I think that this might be the same issue as on
>         buildfarm host
>                tridge:
>         http://build.samba.org/build.cgi/build/5558e6a19258810df8f334960b5774c5c2cfd448.
>
>
>                Probably there is some integer handling issue when reading
>                out/parsing a configuration attribute.
>
>                Cheers,
>                Matthias
>
>                Nadezhda Ivanova wrote:
>
>                    No idea, it works for me and on autobuild. Kamen
>         had the
>                    same issue some
>                    time ago, so I suppose it could be some environment
>                    setting. I will ask him
>                    what he did to stop the failure...
>
>                    On Thu, Feb 10, 2011 at 12:01 AM, Matthieu
>                    Patou<mat at samba.org <mailto:mat at samba.org>
>         <mailto:mat at samba.org <mailto:mat at samba.org>>>  wrote:
>
>
>                        Hello Nadya,
>
>
>                        I've got a weird behavior on my laptop (ubuntu
>         10.10).
>
>                        make test TESTS=acl.python fails even on master
>         (revision
>                        be808123cb2b2bd050edb848bfdeaacc26ab397e)
>                        It's strange because the same branch is ok on my
>                        account on sn-devel.
>
>                        Any idea of what can cause this ?
>
>                        Here is the log of the error.
>
>                        Test: running (/usr/bin/perl
>                      
>          /usr/local/src/samba4/selftest/selftest.pl--prefix=./st
>         --builddir=.
>                        --srcdir=/usr/local/src/samba4
>                      
>          --exclude=/usr/local/src/samba4/source4/selftest/skip
>                        --testlist="/usr/bin/python
>                        /usr/local/src/samba4/source4/selftest/tests.py|"
>                        
>         --exclude=/usr/local/src/samba4/source4/selftest/slow
>                        --socket-wrapper
>                        samba4.ldap.acl.python.dc.&&  touch ./st/st_done) |
>                        /usr/bin/python -u
>                        /usr/local/src/samba4/selftest/filter-subunit
>                      
>          --expected-failures=/usr/local/src/samba4/source4/selftest/knownfail
>                        | tee
>                        ./st/subunit | /usr/bin/python -u
>                        /usr/local/src/samba4/selftest/format-subunit
>                        --prefix=./st --immediate
>                        SOCKET_WRAPPER_DIR=/usr/local/src/samba4/st/w
>                        Version 4.0.0alpha15-GIT-be80812
>                        OPTIONS --configfile=$SMB_CONF_PATH
>                        --maximum-runtime=$SELFTEST_MAXTIME
>                        --target=$SELFTEST_TARGET
>         --basedir=$SELFTEST_TMPDIR
>                        --option=torture:progress=no --format=subunit
>                        WARNING: allowing empty subunit output from
>         ldb.base
>                        WARNING: allowing empty subunit output from
>                        samba4.urgent_replication.python(dc)
>                        WARNING: allowing empty subunit output from
>                        samba4.blackbox.samba3dump
>                        WARNING: allowing empty subunit output from
>                        samba4.blackbox.upgrade
>                        PROVISIONING DC...STARTING SAMBA for dc
>                        DONE
>                        delaying for nbt name registration
>                        samba version 4.0.0alpha15-GIT-be80812 started.
>                        Copyright Andrew Tridgell and the Samba Team
>         1992-2011
>                        Called with maxruntime 7500 - current ts 1297286966
>                        samba: using 'single' process model
>                        Lookup failed - NT_STATUS_IO_TIMEOUT
>                        127.0.0.1 LOCALDC<00>
>                        127.0.0.1 LOCALDC<00>
>                        127.0.0.1 LOCALDC<00>
>                        127.0.0.1 DC1<00>
>                        127.0.0.1 DC1<00>
>                        127.0.0.1 LOCALDC<00>
>                        127.0.0.1 LOCALDC<00>
>                        127.0.0.1 LOCALDC<00>
>                        127.0.0.1 LOCALDC<00>
>                        127.0.0.1 DC1<00>
>                        127.0.0.1 DC1<00>
>                        SAMBA LOG of: localdc
>                        samba version 4.0.0alpha15-GIT-be80812 started.
>                        Copyright Andrew Tridgell and the Samba Team
>         1992-2011
>                        Called with maxruntime 7500 - current ts 1297286966
>                        samba: using 'single' process model
>                        [1/1 in 0s] samba4.ldap.acl.python(dc)
>                        baseDN: DC=samba,DC=example,DC=com
>                        workgroup is SAMBADOMAIN
>                        realm is samba.example.com
>         <http://samba.example.com> <http://samba.example.com>
>                        workgroup is SAMBADOMAIN
>                        realm is samba.example.com
>         <http://samba.example.com> <http://samba.example.com>
>
>                        Adding CN=TESTRODC8,OU=Domain
>                        Controllers,DC=samba,DC=example,DC=com
>                        Adding
>                      
>          CN=krbtgt_TESTRODC8,CN=Users,DC=samba,DC=example,DC=com
>                        Got krbtgt_name=krbtgt_64833
>                        Renaming
>                      
>          CN=krbtgt_TESTRODC8,CN=Users,DC=samba,DC=example,DC=com to
>                        CN=krbtgt_64833,CN=Users,DC=samba,DC=example,DC=com
>                        Adding
>                      
>          CN=TESTRODC8,CN=Servers,CN=Default-First-Site-Name,CN=Sites,CN=Configuration,DC=samba,DC=example,DC=com
>
>                        Adding CN=NTDS
>                      
>          Settings,CN=TESTRODC8,CN=Servers,CN=Default-First-Site-Name,CN=Sites,CN=Configuration,DC=samba,DC=example,DC=com
>
>                        Adding CN=RODC Connection (FRS),CN=NTDS
>                      
>          Settings,CN=TESTRODC8,CN=Servers,CN=Default-First-Site-Name,CN=Sites,CN=Configuration,DC=samba,DC=example,DC=com
>
>                        Adding CN=TESTRODC8,CN=Topology,CN=Domain System
>                      
>          Volume,CN=DFSR-GlobalSettings,CN=System,DC=samba,DC=example,DC=com
>                        Adding SPNs to CN=TESTRODC8,OU=Domain
>                        Controllers,DC=samba,DC=example,DC=com
>                        Setting account password for TESTRODC8$
>                        Enabling account
>                        Adding CN=TESTSRV8,OU=Domain
>                        Controllers,DC=samba,DC=example,DC=com
>                        Adding
>                      
>          CN=TESTSRV8,CN=Servers,CN=Default-First-Site-Name,CN=Sites,CN=Configuration,DC=samba,DC=example,DC=com
>
>                        Adding CN=NTDS
>                      
>          Settings,CN=TESTSRV8,CN=Servers,CN=Default-First-Site-Name,CN=Sites,CN=Configuration,DC=samba,DC=example,DC=com
>
>                        Adding CN=TESTSRV8,CN=Topology,CN=Domain System
>                      
>          Volume,CN=DFSR-GlobalSettings,CN=System,DC=samba,DC=example,DC=com
>                        Adding SPNs to CN=TESTSRV8,OU=Domain
>                        Controllers,DC=samba,DC=example,DC=com
>                        Setting account password for TESTSRV8$
>                        Enabling account
>                        Setting spn HOST/TESTRODC8/SAMBADOMAIN on
>                        CN=TESTRODC8,OU=Domain
>                        Controllers,DC=samba,DC=example,DC=com
>                        Setting spn HOST/TESTRODC8/SAMBADOMAIN on
>                        CN=TESTRODC8,OU=Domain
>                        Controllers,DC=samba,DC=example,DC=com
>                        Setting spn HOST/TESTRODC8 on
>         CN=TESTRODC8,OU=Domain
>                        Controllers,DC=samba,DC=example,DC=com
>                        UNEXPECTED(error):
>                      
>          samba4.ldap.acl.python(dc).__main__.AclSPNTests.test_spn_rodc
>                        REASON: _StringException: _StringException:
>         Content-Type:
>                        text/x-traceback;charset=utf8,language=python
>                        traceback
>                        307
>                        Traceback (most recent call last):
>                         File
>                      
>          "/usr/lib/python2.6/dist-packages/testtools/runtest.py",
>                        line 128, in
>                        _run_user
>                           return fn(*args)
>                         File
>                      
>          "/usr/lib/python2.6/dist-packages/testtools/testcase.py",
>                        line 368,
>                        in _run_test_method
>                           testMethod()
>                         File
>                      
>          "/usr/local/src/samba4/source4/dsdb/tests/python/acl.py",
>                        line 1820,
>                        in test_spn_rodc
>                           self.dc_spn_test(self.rodcctx)
>                         File
>                      
>          "/usr/local/src/samba4/source4/dsdb/tests/python/acl.py",
>                        line 1673,
>                        in dc_spn_test
>                           self.replace_spn(self.ldb_user1, ctx.acct_dn,
>                        "HOST/%s" % (ctx.myname))
>                         File
>                      
>          "/usr/local/src/samba4/source4/dsdb/tests/python/acl.py",
>                        line 1609,
>                        in replace_spn
>                           _ldb.modify(msg)
>                        LdbError: (19, 'LDAP error 19
>                        LDAP_CONSTRAINT_VIOLATION -<error in module
>                        acl: Constraint violation (19)> <>')
>                        0
>
>                        checking samaccountname
>                        Deleted CN=TESTRODC8,OU=Domain
>                        Controllers,DC=samba,DC=example,DC=com
>                        Deleted CN=RODC Connection (FRS),CN=NTDS
>                      
>          Settings,CN=TESTRODC8,CN=Servers,CN=Default-First-Site-Name,CN=Sites,CN=Configuration,DC=samba,DC=example,DC=com
>
>                        Deleted CN=NTDS
>                      
>          Settings,CN=TESTRODC8,CN=Servers,CN=Default-First-Site-Name,CN=Sites,CN=Configuration,DC=samba,DC=example,DC=com
>
>                        Deleted
>                      
>          CN=TESTRODC8,CN=Servers,CN=Default-First-Site-Name,CN=Sites,CN=Configuration,DC=samba,DC=example,DC=com
>
>                        Deleted CN=TESTRODC8,CN=Topology,CN=Domain System
>                      
>          Volume,CN=DFSR-GlobalSettings,CN=System,DC=samba,DC=example,DC=com
>                        Deleted
>                        CN=krbtgt_64833,CN=Users,DC=samba,DC=example,DC=com
>                        checking samaccountname
>                        Deleted CN=TESTSRV8,OU=Domain
>                        Controllers,DC=samba,DC=example,DC=com
>                        Deleted CN=NTDS
>                      
>          Settings,CN=TESTSRV8,CN=Servers,CN=Default-First-Site-Name,CN=Sites,CN=Configuration,DC=samba,DC=example,DC=com
>
>                        Deleted
>                      
>          CN=TESTSRV8,CN=Servers,CN=Default-First-Site-Name,CN=Sites,CN=Configuration,DC=samba,DC=example,DC=com
>
>                        Deleted CN=TESTSRV8,CN=Topology,CN=Domain System
>                      
>          Volume,CN=DFSR-GlobalSettings,CN=System,DC=samba,DC=example,DC=com
>                        baseDN: DC=samba,DC=example,DC=com
>                        workgroup is SAMBADOMAIN
>                        realm is samba.example.com
>         <http://samba.example.com> <http://samba.example.com>
>                        workgroup is SAMBADOMAIN
>                        realm is samba.example.com
>         <http://samba.example.com> <http://samba.example.com>
>
>                        Adding CN=TESTRODC8,OU=Domain
>                        Controllers,DC=samba,DC=example,DC=com
>                        Adding
>                      
>          CN=krbtgt_TESTRODC8,CN=Users,DC=samba,DC=example,DC=com
>                        Got krbtgt_name=krbtgt_36018
>                        Renaming
>                      
>          CN=krbtgt_TESTRODC8,CN=Users,DC=samba,DC=example,DC=com to
>                        CN=krbtgt_36018,CN=Users,DC=samba,DC=example,DC=com
>                        Adding
>                      
>          CN=TESTRODC8,CN=Servers,CN=Default-First-Site-Name,CN=Sites,CN=Configuration,DC=samba,DC=example,DC=com
>
>                        Adding CN=NTDS
>                      
>          Settings,CN=TESTRODC8,CN=Servers,CN=Default-First-Site-Name,CN=Sites,CN=Configuration,DC=samba,DC=example,DC=com
>
>                        Adding CN=RODC Connection (FRS),CN=NTDS
>                      
>          Settings,CN=TESTRODC8,CN=Servers,CN=Default-First-Site-Name,CN=Sites,CN=Configuration,DC=samba,DC=example,DC=com
>
>                        Adding CN=TESTRODC8,CN=Topology,CN=Domain System
>                      
>          Volume,CN=DFSR-GlobalSettings,CN=System,DC=samba,DC=example,DC=com
>                        Adding SPNs to CN=TESTRODC8,OU=Domain
>                        Controllers,DC=samba,DC=example,DC=com
>                        Setting account password for TESTRODC8$
>                        Enabling account
>                        Adding CN=TESTSRV8,OU=Domain
>                        Controllers,DC=samba,DC=example,DC=com
>                        Adding
>                      
>          CN=TESTSRV8,CN=Servers,CN=Default-First-Site-Name,CN=Sites,CN=Configuration,DC=samba,DC=example,DC=com
>
>                        Adding CN=NTDS
>                      
>          Settings,CN=TESTSRV8,CN=Servers,CN=Default-First-Site-Name,CN=Sites,CN=Configuration,DC=samba,DC=example,DC=com
>
>                        Adding CN=TESTSRV8,CN=Topology,CN=Domain System
>                      
>          Volume,CN=DFSR-GlobalSettings,CN=System,DC=samba,DC=example,DC=com
>                        Adding SPNs to CN=TESTSRV8,OU=Domain
>                        Controllers,DC=samba,DC=example,DC=com
>                        Setting account password for TESTSRV8$
>                        Enabling account
>                        Setting spn HOST/TESTSRV8/SAMBADOMAIN on
>                        CN=TESTSRV8,OU=Domain
>                        Controllers,DC=samba,DC=example,DC=com
>                        Setting spn HOST/TESTSRV8/SAMBADOMAIN on
>                        CN=TESTSRV8,OU=Domain
>                        Controllers,DC=samba,DC=example,DC=com
>                        Setting spn HOST/TESTSRV8 on CN=TESTSRV8,OU=Domain
>                        Controllers,DC=samba,DC=example,DC=com
>                        UNEXPECTED(error):
>                      
>          samba4.ldap.acl.python(dc).__main__.AclSPNTests.test_spn_rwdc
>                        REASON: _StringException: _StringException:
>         Content-Type:
>                        text/x-traceback;charset=utf8,language=python
>                        traceback
>                        305
>                        Traceback (most recent call last):
>                         File
>                      
>          "/usr/lib/python2.6/dist-packages/testtools/runtest.py",
>                        line 128, in
>                        _run_user
>                           return fn(*args)
>                         File
>                      
>          "/usr/lib/python2.6/dist-packages/testtools/testcase.py",
>                        line 368,
>                        in _run_test_method
>                           testMethod()
>                         File
>                      
>          "/usr/local/src/samba4/source4/dsdb/tests/python/acl.py",
>                        line 1817,
>                        in test_spn_rwdc
>                           self.dc_spn_test(self.dcctx)
>                         File
>                      
>          "/usr/local/src/samba4/source4/dsdb/tests/python/acl.py",
>                        line 1673,
>                        in dc_spn_test
>                           self.replace_spn(self.ldb_user1, ctx.acct_dn,
>                        "HOST/%s" % (ctx.myname))
>                         File
>                      
>          "/usr/local/src/samba4/source4/dsdb/tests/python/acl.py",
>                        line 1609,
>                        in replace_spn
>                           _ldb.modify(msg)
>                        LdbError: (19, 'LDAP error 19
>                        LDAP_CONSTRAINT_VIOLATION -<error in module
>                        acl: Constraint violation (19)> <>')
>                        0
>
>                        samba: EOF on stdin - terminating
>                        checking samaccountname
>                        Deleted CN=TESTRODC8,OU=Domain
>                        Controllers,DC=samba,DC=example,DC=com
>                        Deleted CN=RODC Connection (FRS),CN=NTDS
>                      
>          Settings,CN=TESTRODC8,CN=Servers,CN=Default-First-Site-Name,CN=Sites,CN=Configuration,DC=samba,DC=example,DC=com
>
>                        Deleted CN=NTDS
>                      
>          Settings,CN=TESTRODC8,CN=Servers,CN=Default-First-Site-Name,CN=Sites,CN=Configuration,DC=samba,DC=example,DC=com
>
>                        Deleted
>                      
>          CN=TESTRODC8,CN=Servers,CN=Default-First-Site-Name,CN=Sites,CN=Configuration,DC=samba,DC=example,DC=com
>
>                        Deleted CN=TESTRODC8,CN=Topology,CN=Domain System
>                      
>          Volume,CN=DFSR-GlobalSettings,CN=System,DC=samba,DC=example,DC=com
>                        Deleted
>                        CN=krbtgt_36018,CN=Users,DC=samba,DC=example,DC=com
>                        checking samaccountname
>                        Deleted CN=TESTSRV8,OU=Domain
>                        Controllers,DC=samba,DC=example,DC=com
>                        Deleted CN=NTDS
>                      
>          Settings,CN=TESTSRV8,CN=Servers,CN=Default-First-Site-Name,CN=Sites,CN=Configuration,DC=samba,DC=example,DC=com
>
>                        Deleted
>                      
>          CN=TESTSRV8,CN=Servers,CN=Default-First-Site-Name,CN=Sites,CN=Configuration,DC=samba,DC=example,DC=com
>
>                        Deleted CN=TESTSRV8,CN=Topology,CN=Domain System
>                      
>          Volume,CN=DFSR-GlobalSettings,CN=System,DC=samba,DC=example,DC=com
>                        command: python
>                      
>          /usr/local/src/samba4/source4/dsdb/tests/python/acl.py
>                        $SERVER -U"$USERNAME%$PASSWORD" -W $DOMAIN 2>&1 |
>                        /usr/local/src/samba4/selftest/filter-subunit
>                        --fail-on-empty
>                        --prefix="samba4.ldap.acl.python(dc)."
>                        expanded command: python
>                      
>          /usr/local/src/samba4/source4/dsdb/tests/python/acl.py
>                        localdc
>                        -U"Administrator%locDCpass1" -W SAMBADOMAIN 2>&1 |
>                        /usr/local/src/samba4/selftest/filter-subunit
>                        --fail-on-empty
>                        --prefix="samba4.ldap.acl.python(dc)."
>                        ERROR: Testsuite[samba4.ldap.acl.python(dc)]
>                        REASON: Exit code was 1
>
>                         errors[2]
>
>                        ./bin/samba exited with no error
>
>                        FAILED (0 failures and 2 errors in 1 testsuites)
>
>                        A summary with detailed information can be
>         found in:
>                         ./st/summary
>                        ERROR: test failed with exit code 1
>                        make: *** [test] Erreur 1
>
>                        Matthieu.
>
>                        --                 Matthieu Patou
>                        Samba Team http://samba.org
>                        Private repo
>         http://git.samba.org/?p=mat/samba.git;a=summary
>
>
>
>
>
>
>
>
>



More information about the samba-technical mailing list