make test TESTS=acl.python fails
abartlet at samba.org
Thu Feb 10 03:11:10 MST 2011
On Thu, 2011-02-10 at 11:57 +0200, Nadezhda Ivanova wrote:
> Hi Matthias,
> I am OK with the changes in create_descriptor.c, although I do not think
> this is the cause of the problem as it is not actually possible to have so
> many ACEs as to overflow these counters, we would run out of memory before
> that. For the other files ping Andrew Bartlett.
Honestly, my answer on the remaining changes is no. There is just way
to much churn with this stuff, and changing from unsigned int to
uint32_t seems quite pointless, as is the worry that when walking over
an array of at most 64, that we might somehow end up at 2^31.
I understand your passion for ensuring this is is 'right', but I think
we have other things that would be better to spend the analysis on.
Andrew Bartlett http://samba.org/~abartlet/
Authentication Developer, Samba Team http://samba.org
Samba Developer, Cisco Inc.
More information about the samba-technical