[PATCH 2/7] ldb:ldbdel tool - use LDB result constants for consistency
idra at samba.org
Wed Feb 9 06:38:05 MST 2011
Sorry I did not have time.
But feel free to push if they are consistent with what we discussed.
On Wed, 2011-02-09 at 09:18 +0100, Matthias Dieter Wallnöfer wrote:
> have you already managed to perform a review of these patches?
> Matthias Dieter Wallnöfer wrote:
> > Simo,
> > under
> > http://gitweb.samba.org/samba.git/?p=mdw/samba.git;a=log;h=refs/heads/ldb_tools
> > you can find an updated version of the patches which should now
> > address your concerns.
> > Please tell me if you can live with them.
> > Cheers,
> > Matthias
> > simo wrote:
> >> On Fri, 2011-02-04 at 19:09 +0100, Matthias Dieter Wallnöfer wrote:
> >>> Simo,
> >>> you mean on each return/exit "-1" case LDB_ERR_OPERATIONS_ERROR? Do I
> >>> understand it correctly?
> >> Given you want to normally return LDB errors, it would make it
> >> consistent to return the generic operations error, when you don't have
> >> anything better to return.
> >> Simo.
Samba Team GPL Compliance Officer <simo at samba.org>
Principal Software Engineer at Red Hat, Inc. <simo at redhat.com>
More information about the samba-technical