s3: allowing '$' in add user to group script

Volker Lendecke Volker.Lendecke at SerNet.DE
Wed Feb 2 10:57:40 MST 2011

On Tue, Feb 01, 2011 at 07:14:39PM +0100, Stefan (metze) Metzmacher wrote:
> is this patch ok?
> http://gitweb.samba.org/?p=metze/samba/wip.git;a=commitdiff;h=2a8cfacb5df2e2181cdc106e2554aa4e1ba39149
> The difference is that we pass allow_trailing_dollar=true to
> talloc_string_sub2().
> But allow_trailing_dollar means more that just '$'.

talloc_string_sub2 is one of these obscure routines... What
else does allow_trailing_dollar==true mean?

If it meant that we allow machine accounts to be added to
and removed from groups, then I think we have to do it. But
on the other hand I'm not paranoid enough I think.


SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen

More information about the samba-technical mailing list