Gratuitous change from init_samba_module to samba_init_module in master considered bad ...

Jeremy Allison jra at samba.org
Fri Dec 30 22:14:24 MST 2011


On Fri, Dec 30, 2011 at 07:23:58PM -0800, Richard Sharpe wrote:
> Hi,
> 
> It seems that in this commit, or there abouts:
> http://gitweb.samba.org/?p=samba.git;a=commit;h=7d33ec3dfe78723d62f4941684060baeb9c4bda6
> 
> changed the name of the module init function from init_samba_module
> (which it was in Samba 3.5.x and 3.6.x) to samba_init_module. (I think
> I have that correct.)
> 
> While all Samba VFS modules that are shared objects will be shielded
> from this change, all static modules will be forced to make changes
> that should not be needed.
> 
> Did we really need to make that gratuitous change?

And if not, shall we put it back the way it was ? :-)


More information about the samba-technical mailing list