Socket draining for sys_recvfile() (patch for 'reverse sendfile')

[Andrew Bartlett]

On Fri, 2011-12-30 at 14:13 +1100, Andrew Bartlett wrote:

> I've been testing the disk full semantics, and in 3.5.11, they are
> certainly not correct, even when just using the fallback:
> 
> Using a small flash drive attached to my NAS, with about 1MB free, with
> 'min recvfile size = 1':
> 
> [abartlet at ruth netgear-src]$ /data/samba/git/samba/bin/smbclient3 //nas-02-22-94/USB_FLASH_1 -Uabartlet%penguin
> Domain=[NETGEAR] OS=[Unix] Server=[Samba 3.5.11]
> smb: \> rm centos.iso2
> smb: \> put /data/vm/cdroms/CentOS-5.5-x86_64-bin-DVD-1of2.iso centos.iso2
> cli_push returned NT_STATUS_INVALID_NETWORK_RESPONSE
> putting file /data/vm/cdroms/CentOS-5.5-x86_64-bin-DVD-1of2.iso as \centos.iso2 (66.0 kb/s) (average 66.0 kb/s)
> smb: \> ^C
> 
> with 'min recvfile size = 0':
> [abartlet at ruth netgear-src]$ /data/samba/git/samba/bin/smbclient3 //nas-02-22-94/USB_FLASH_1 -Uabartlet%penguin
> Domain=[NETGEAR] OS=[Unix] Server=[Samba 3.5.11]
> smb: \> rm centos.iso2
> smb: \> put /data/vm/cdroms/CentOS-5.5-x86_64-bin-DVD-1of2.iso centos.iso2
> cli_push returned NT_STATUS_DISK_FULL
> putting file /data/vm/cdroms/CentOS-5.5-x86_64-bin-DVD-1of2.iso as \centos.iso2 (76.0 kb/s) (average 76.0 kb/s)
> smb: \> 
> 
> I have a capture of both at: http://abartlet.net/recvfile-broken.cap.gz  (I also get similar behaviour with my patch)

> I'll try out master once I sort out some unrelated loadparm issues on this Sparc based platform

I've tested this out with master with a small partition on my x86 Linux
laptop, with identical results, so this issue is not
platform-dependent.  

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org