Socket draining for sys_recvfile() (patch for 'reverse sendfile')
abartlet at samba.org
Sun Dec 25 14:38:29 MST 2011
On Sat, 2011-12-24 at 21:02 -0800, Jeremy Allison wrote:
> Completely correct. You've found a bug in the splice() codepath !
> Well done & thanks.
No worries! Now that is fixed up, I'm much more confident to include it
in the patch for reverse sendfile.
> The reason this hasn't been an issue up until now is that
> the splice() codepath is (a) slower than the read/write path,
> so was never used by default, (b) the Isilon code didn't exercise
> this codepath at all - they used a custom written sendfile()
> implementation and (c) it's in an error path rarely taken
> (probably only on disk full).
Yeah, and that is the error case I need to test.
> I've fixed this in master, and have logged a bug to get it fixed
> in 3.6.2 and 3.5.next (I'll tag you for the patch review for
> 3.6.x and 3.5.x :-).
I'll be glad to!
Andrew Bartlett http://samba.org/~abartlet/
Authentication Developer, Samba Team http://samba.org
More information about the samba-technical