Revert making public of the samba-module library.
Jelmer Vernooij
jelmer at samba.org
Sat Dec 3 21:04:55 MST 2011
Am 03/12/11 23:12, schrieb Andrew Bartlett:
> On Sat, 2011-12-03 at 08:37 +0100, Jelmer Vernooij wrote:
>> Revert making public of the samba-module library.
> This seems sensible (and I wish it had been suggested earlier). That
> said, I'm surprised by your revert changed things other than the wscript
> files. Was there a reason to revert the tidy up of the namespace and
> function prefixes?
>
Thanks. The main reason I reverted the entire change was just that it
was easier, and it didn't seem necessary to keep the other changes when
the functions weren't publicly exposed (having a samba_ prefix for
internal functions doesn't seem useful).
I wonder what the most appropriate place for the modules is. It doesn't
really belong in lib/util, which is about *generic* convenience utility
functions, not stuff that's specific to Samba.
Cheers,
Jelmer
More information about the samba-technical
mailing list