about patch ed564fb04

Matthieu Patou mat at samba.org
Sat Dec 3 15:10:19 MST 2011

Hello Metze,

I had a look at this patch:


I don't see anything wrong, but I think that was you are doing for the 
replmd_replicated_apply_merge function is overkill all the comparison 
with old parameters. If the recycle bin is not enabled then we can meet 
only once the case when another DC is replicating to us with the 
isDeleted attribute set: when the object is known by us and the other DC 
is notifying us that this object is now a tombstone, if the recycle-bin 
is enabled then we don't care because it's not a good idea to add 
isRecycled while replicating an object.

Concerning this patch you are right:

But I don't understand your commit message.


Matthieu Patou
Samba Team

More information about the samba-technical mailing list