Fw: samba-tool command structure

Andrew Bartlett abartlet at samba.org
Tue Aug 30 21:32:15 MDT 2011

On Fri, 2011-08-26 at 13:39 -0400, Giampaolo Lauria wrote:
> Hi Jelmer,
> I am sorry it took so long to get back to you. Please keep in mind that I 
> am a new samba team member, so I feel that your input is very important.
> Here are my answers to your questions:
> 1) For the delegation command, I first would like to say that it has been 
> a top-level command even before I started looking at this regrouping work.
> While I still think it should be a top-level command due to the fact that 
> it has many subcommands, we should have its authors answer your specific 
> question.
> >From the command, I see:
> # Copyright Matthieu Patou mat at samba.org 2010
> # Copyright Stefan Metzmacher metze at samba.org 2011
> # Copyright Bjoern Baumbach bb at sernet.de 2011
> Hopefully one of those gentlemen may give us a feedback.
> 2) In general, I think it is easier to find things that are grouped by 
> category. It would also be nice to have a single object (diag in our case) 
> as a single entry for the administrator to validate different 
> configuration settings.
> I think testparm belongs to a diag-like command.
> After looking at the "testparm" code in more details, I noticed that it 
> does nothing more than validating the values for each keyword in the 
> config file. The fact that it allows the user to specify a section or a 
> keyword, is just to simply dump that section or keyword after validating 
> all the keyword values anyway. Unless I am missing something, I am not 
> sure how useful the keyword value(s) dump can be or whether it is a bug in 
> the command. 
> I am not crazy about the diag naming myself but could not come up with 
> anything better for the time being. Please feel free to suggest a better 
> name.

Let's not move anything into diag until we have a consensus on a better
name.  I would rather not move things around too often, and for example
testparm is a very old name in Samba and I think samba-tool testparm is
appropriate for now.

Andrew Bartlett

Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org

More information about the samba-technical mailing list