[PATCH] for tdb (adds some log message)

Rusty Russell rusty at rustcorp.com.au
Mon Aug 29 18:14:33 MDT 2011

On Mon, 29 Aug 2011 14:23:44 +0200, Michael Adam <obnox at samba.org> wrote:
> Hi Rusty,
> in tdb, transaction_start is logged if it starts
> a nested transaction. I'd like to be more consistent
> and also log new top level transactions.
> I recently adapted the dbwrap_ctdb code to behave
> correspondingly: This originally only logged the start of
> top level transactions and not of nested ones. I added
> logging of nested transaction to this module.
> Attached find a patch for this.
> What do you think?

I think we should not log either, but we should log failures.

DEBUG_TRACE is almost entirely unused; I think a separate tracing
interface is wanted for this kind of thing, rather than a potentially
expensive log call.


More information about the samba-technical mailing list