An updated Samba VFS for Ceph using the libceph user-space interface

Richard Sharpe realrichardsharpe at gmail.com
Tue Aug 23 12:59:21 MDT 2011


On Fri, Aug 19, 2011 at 1:51 PM, Richard Sharpe
<realrichardsharpe at gmail.com> wrote:
> Hi,
>
> Attached is a slightly cleaned up Ceph VFS patch plus a couple of
> other misc ones.
>
> The clean-ups to the Ceph VFS are:
>
> 1. Remove C++ style comments
> 2. Fix the OpenDir routine to set errno when an error occurs
> 3. Remove some unused code and other cruft.
>
> The code has been tested via Windows 2K03 to ensure that it can create
> files and folders and that we can view folders. It has also been
> tested to ensure that reads and writes to files work, with several
> megabyte plus copies done via smbclient. Other testing continues.
>
> I think it is functional at this point.
>
> I have added Brian so he can respond with a Signed-Off-By as well.
>
> Signed-Off-By: Richard Sharpe <realrichardsharpe at gmail.com>

One problem I can foresee is that if /usr/include/ceph/libceph.h is
not on the system when the builder runs make the build will fail when
vfs_ceph.c fails to compile. That would be a pain most people who, I
imagine, are simply not interested in Ceph.

It would probably be wise to add a test to configure.in for the
presence of libceph.h and only add the ceph VFS to the list of modules
to be built if it is.

I guess I can make that change in the next few days and resubmit :-)

-- 
Regards,
Richard Sharpe


More information about the samba-technical mailing list