require a working mmap for Samba 4.0?
idra at samba.org
Mon Aug 15 06:58:29 MDT 2011
On Mon, 2011-08-15 at 17:11 +1000, Andrew Bartlett wrote:
> On Mon, 2011-08-15 at 08:44 +0200, Volker Lendecke wrote:
> > On Mon, Aug 15, 2011 at 11:04:20AM +1000, Andrew Bartlett wrote:
> > > On Mon, 2011-08-15 at 00:46 +0000, simo wrote:
> > >
> > > > Btw, while making them I noticed that we test mmap and set HAVE_MMAP
> > > > accordingly, but then we do not wrap all mmap calls withing HAVE_MMAP
> > > > ifdefs. Not sure we actually can work w/o mmap, so I wonder if we
> > > > shouldn't rather turn the configure test into a fatal failure if mmap is
> > > > not found.
> > >
> > > I would support this, but what do we then do with HP-UX which is on the
> > > mmap blacklist?
> > The reason why HP/UX is on the mmap blacklist is afaik the
> > lack of coherence between mmap and read/write calls. This
> > should not matter for the use case Simo has.
> What do you think of removing #ifdef HAVE_MMAP and having a #ifdef
> COHERNET_MMAP in tdb only?
Works for me.
Samba Team GPL Compliance Officer <simo at samba.org>
Principal Software Engineer at Red Hat, Inc. <simo at redhat.com>
More information about the samba-technical