MAP_ANONYMOUS isn't portable
simo
idra at samba.org
Sun Aug 14 18:46:37 MDT 2011
On Sun, 2011-08-14 at 20:46 +1000, Andrew Bartlett wrote:
> Simo and Andreas,
>
> I wasn't sure if you noticed, but a large number of hosts on the build
> farm now fail to build because MAP_ANONYMOUS isn't portable.
>
> It was introduced in:
>
> commit 4fef4fe4986245bfd0ac0c3a3d3a10d330bae09c
> Author: Simo Sorce <idra at samba.org>
> Date: Wed Apr 20 16:28:57 2011 -0400
>
> s3-prefork: implement prefork framework
>
> Primarily built for forked off rpc service daemons, but not tied to
> rpc
> services and generic enough to be used elsewhere easily.
>
> Signed-off-by: Andreas Schneider <asn at samba.org>
>
> An example failing build is:
>
> http://build.samba.org/build.cgi/build/d24732a709b239e1896103e0ce366b821eef7d0b
>
I have 3 patches in autobuild that should take care of this.
Btw, while making them I noticed that we test mmap and set HAVE_MMAP
accordingly, but then we do not wrap all mmap calls withing HAVE_MMAP
ifdefs. Not sure we actually can work w/o mmap, so I wonder if we
shouldn't rather turn the configure test into a fatal failure if mmap is
not found.
Simo.
--
Simo Sorce
Samba Team GPL Compliance Officer <simo at samba.org>
Principal Software Engineer at Red Hat, Inc. <simo at redhat.com>
More information about the samba-technical
mailing list