gpo patches

[Amitay Isaacs]

Hi Metze,

On Sat, Aug 6, 2011 at 9:46 AM, Andrew Bartlett <abartlet at samba.org> wrote:

> On Fri, 2011-08-05 at 21:19 +0200, Stefan (metze) Metzmacher wrote:
> > Hi Andrew,
> > hi Amitay,
> >
> > is it ok to push this patch?
> >
> http://gitweb.samba.org/?p=metze/samba/wip.git;a=commitdiff;h=a8e330a5cd16f5dd2263bbd34a7371ce4125448a
> >
> > We should not specify autogenerated values on ldap add operations.
>

Thanks for the tip. I just copied the C code to python without realizing the
automatic generation
of objectclass values.


> >
> > I also think it's wrong to copy the
> > SACL from the AD object without modification to the SACL of the
> > file/directory:
> >
> http://gitweb.samba.org/?p=metze/samba/wip.git;a=commitdiff;h=ff82aeb190e142e802ab66fe0dcee5e9150ac4c5
>
>
Again, the C code only converted DACL and not SACL. Does the SACL conversion
follow the same
rules as DACL conversion? Would you know where I can find any information on
this?

Thanks.

Amitay.