spoolss talloc problem

Andreas Schneider asn at samba.org
Mon Aug 8 07:13:12 MDT 2011

On Monday 08 August 2011 18:42:16 tridge at samba.org wrote:
> Hi Simo,

Hi Tridge,

> http://git.samba.org/?p=tridge/samba.git;a=commitdiff;h=d24af812d76059c2f3b
> 917b791c77175b388811a
> it just ensures that a talloc chunk that is part way through being
> freed doesn't have an invalid tc->prev pointer.
> I'm still testing the fix, but it does seem to fix your issue. It is
> also faster than the existing code (as we no longer call the expensive
> talloc_parent_chunk() call when we don't need it).

I've tested the fix here and I wasn't able to reprodue the problem. However I 
have a patch which fixes the problem in a different way and makes sure the 
memory context doesn't get so huge.


Feel free to push both :)


	-- andreas

Andreas Schneider                   GPG-ID: F33E3FC6
Samba Team                             asn at samba.org

More information about the samba-technical mailing list