[PATCH] a common 'make test'

Andrew Bartlett abartlet at samba.org
Tue Apr 26 04:02:59 MDT 2011


I have now demonstrated a combined 'make test' using Samba3 and Samba4,
including the changes that I've been discussing with Simo around the
krb5 PAC.  

It will mean that a top level build will test Samba4 and Samba3 in 'make
test', and provide the platform for combined testing (I'm still working
out details around nss_wrapper for that). 

http://git.samba.org/?p=abartlet/samba.git/.git;a=shortlog;h=refs/heads/merge-test-minimal

Of particular note are:

Use the resolv:host file for fake DNS replies (allowing ADS testing in
the 'make test' environment)
http://git.samba.org/?p=abartlet/samba.git/.git;a=commitdiff;h=cfcdc995c37158003f138cc734fdd3bccd471dec

This patch avoids doing real (and duplicate) DNS lookups when we already
know the AD DC's server address and are performing CLDAP:
http://git.samba.org/?p=abartlet/samba.git/.git;a=commitdiff;h=deecc2e5b9445754b3b855d6cfe621a1f8e16747

(and the patches I've already mentioned in the other thread with Simo). 

Of note, but not currently proposed for merge are my attempts to build
combined s3/s4 tests.  These patches are in:
http://git.samba.org/?p=abartlet/samba.git/.git;a=shortlog;h=refs/heads/merge-test-2

In particular, this one is to use the private ldap_init_fd() function to
allow LDAP connections via socket_wrapper:
http://git.samba.org/?p=abartlet/samba.git/.git;a=commitdiff;h=1c1b13ca91fee39d8adab724413bd18e39f2d315

I would appriciate comments on this, and suggestions on how best to
solve the need to push OpenLDAP via socket_wrapper.

With this patch I've been able to test 'net join' and therefore the
CLDAP changes in 'net' and 'winbindd'.  The only part I can't easily
test is the small consequential change I made to the idmap_adex code,
which seems to be for Likewise 'Cells'. 

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org



More information about the samba-technical mailing list