Make --enable-s3build the default in the top level build?
abartlet at samba.org
Wed Apr 20 06:03:59 MDT 2011
On Wed, 2011-04-20 at 12:05 +0200, Stefan (metze) Metzmacher wrote:
> Hi Andrew,
> > I was wondering if it would be OK to make --enable-s3build the default
> > (no longer optional) in the top level build? I've been building with it
> > for quite some time, and it seems to 'just work'.
> I'm also using it for a few weeks now.
> > This option enables a waf build of all of Samba, producing binaries for
> > 'Samba3' and 'Samba4' that are linked to common shared libraries. It is
> > still a work in progress, but pending only the kerberos fixes I'm
> > currently working out with Simo, it passes a combined make test.
> > The combined test is why I ask: We currently have 4 build systems in
> > Samba (autoconf-s3, waf-s3, toplevel, toplevel-s3build), and I think
> > this is too many - I would like to reduce this to 3.
> > In particular, what I'm hoping is that I can write tests that test
> > Samba3 and Samba4 interactions without the complexity of them being
> > conditional.
> > Take for example the test metze and I have been working on to test
> > Samba3's winbind in a Samba4 domain. I don't want to have to make this
> > important test conditional - instead I want to ensure we get this
> > working, and then we keep this working.
> > This won't impact the s3-waf build, or the autoconf build - any combined
> > tests will be added to the top level build only.
> What tests will run in a 'make test' then?
> all s3 tests, all s3 tests and the combined ones?
Initially just the s4 tests, when I get the s3 tests going I would like
it to be both. s3/s4 interop tests will be added to the s4 tests (as s3
tests still need to run in autoconf and s3-waf).
> While I think that should be the default, I'd like to have an option to run
> just a subset. So that we can do things in parallel within the autobuild
The test system allows exactly this:
buildtools/bin/waf test --target=samba3
buildtools/bin/waf test --target=samba4
buildtools/bin/waf test --target=samba
(Default, currently samba4, if agreed then soon to be all Samba)
> One autobuild needs ca. 47 mins (while the s4 make test takes about 44
> It would be nice to reduce the time...
It would be nice to reduce it. The bad news is that the 'All Samba'
test time is 1h or so currently. We certainly could have autobuild
doing some things in parallel. I will note that while the time is
frustrating, it is not time the developer must spend personally. I
actually think we can find the 15mins extra it costs if we improve tdb
and ldb performance.
Andrew Bartlett http://samba.org/~abartlet/
Authentication Developer, Samba Team http://samba.org
More information about the samba-technical