patch for ldb: add application flags
idra at samba.org
Sat Apr 16 08:50:51 MDT 2011
On Sat, 2011-04-16 at 11:51 +0400, Matthieu Patou wrote:
> Hello Tridge and Simo,
> Can you have a look at this patch 8ef7e17 ldb: add applications flags
> and function to manipulate the at
> It's about adding flags to in the ldb's handle of a request, so that
> each application can define its own flags.
> Unless I misunderstood it should be what we discussed 2/3 weeks ago on
> IRC and agreed on.
If the getter/setter needs to be used by the application then you have
to put it in ldb.h, ldb_modules.h is used only by modules, and should
never be required for apps using ldb.
Also it may make sense to check that handle is not NULL before
referencing and returning an error otherwise. Just paranoia, but it cost
nothing to do.
Beyond that it looks ok to me.
Samba Team GPL Compliance Officer <simo at samba.org>
Principal Software Engineer at Red Hat, Inc. <simo at redhat.com>
More information about the samba-technical