patches to merge string and charset code

[Andrew Bartlett]

On Tue, 2011-04-12 at 12:02 +0200, Stefan (metze) Metzmacher wrote:
> Hi Andrew,
> 
> > It is in
> > http://git.samba.org/?p=abartlet/samba.git/.git;a=shortlog;h=refs/heads/merge-str
> 
> This is incomplete the function itself still has the wrong prototype
> and returns -1 in one case.
> 
> http://git.samba.org/?p=abartlet/samba.git/.git;a=commitdiff;h=c49d4de44fc88096f69dbca8bf54160c3920ce7d
> 
> This needs to be squashed to
> http://git.samba.org/?p=abartlet/samba.git/.git;a=commitdiff;h=0264c3b4c2320d258160ab0e9cb4d73a4fd74c93
> 
> BTW: thanks for making small commits, it's much easier to review:-)
> 
> But note that I only looked for high level bugs, I haven't verified that
> every little
> detail is correct...

Thanks for looking over those, it's really appreciated.  I'll probably
drop or work with Tridge to re-review the -1 changes for now, as I
wasn't able to meet Tridge's goal of removing the magic -1 behaviour and
the strlen_w() it depended on.  You are correct that removing special -1
behaviour needs to be a distinct effort anyway. 

I don't expect you to verify that every little detail is correct, that's
the job of the automated tests.  Any extra examples for the testsuite
would be most welcome.

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org