ldb: support for modrdn LDIF

[Stefan (metze) Metzmacher]

Am 09.04.2011 14:25, schrieb simo:
> On Sat, 2011-04-09 at 11:43 +0200, Stefan (metze) Metzmacher wrote:
>> Hi,
>>
>> I've added support for modrdn in LDIF, this looks like this:
>>
>> dn: cn=Ursula Hampster,ou=Alumni Association,ou=People,o=University of
>> Michiga
>>  n,c=TEST
>> changetype: moddn
>> newrdn: cn=Hampster Ursula
>> deleteoldrdn: 1
>> newsuperior: ou=Alumni Association,ou=People,o=University of Michigan,c=TEST
>>
>> dn: cn=Hampster Ursula,ou=Alumni Association,ou=People,o=University of
>> Michiga
>>  n,c=TEST
>> changetype: modrdn
>> newrdn: cn=Ursula Hampster
>> deleteoldrdn: 1
>>
>> The code can be found here:
>> http://gitweb.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/heads/master4-ldb
>>
>> I've added a ldb_ldif_parse_modrdn() helper function which parses the modrdn
>> related stuff out of a ldb_message. I think this is better than changing
>> struct ldb_ldif, as that would be an ABI breakage and we would need to
>> change the version
>> to 2.0.0.
>>
>> As ldb_ldif_parse_modrdn() is a new public function I changed the
>> version to 1.1.0 instead of 1.0.3.
>>
>> Is it ok to push this?
> 
> Ok to push,

thanks.

> but no need for a new Y version, 1.0.4 is enough as a new
> function doesn't cause any incompatibility with previous library
> versions.

I think we should make it clear if we add new features and apply this rule
for X.Y.Z versions:

if X == 0:
    /* X == 0, means there's no stable API/ABI yet */
    - bug fixes and new features should trigger an update of Z.
    - incompatible changes should trigger an update of Y.
else
    - important bug fixes should trigger an update of Z.
    - new features should trigger an update of Y
    - incompatible changes should trigger an update of X.

It would be nice if we could add checks for this into the ABI checking code.

metze

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 262 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20110411/f0143429/attachment.pgp>