[SCM] Samba Shared Repository - branch master updated

[Guenther Deschner]

Hi Andrew,

On 04/04/2011 01:32 PM, Andrew Bartlett wrote:
> The branch, master has been updated
>         via  a3ef974 s3-rpc_server Remove comment, yes the key is correct.
>         via  77e6716 s3-auth consolidate create_local_token() into make_server_info_krb5()
>         via  841d0bc s3-selftest Remove more instances of /tmp in test_smbclient_s3.sh
>         via  6351dee s3-selftest Add testing of kerberos login
>         via  55134c9 s4-credentials Add a command line hook to set the kerberos credentials cache
>         via  ffb6003 s3-selftest Disable log rotation in 'make test'
>        from  513574a talloc - some documentation changes
>
> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
>
>
> - Log -----------------------------------------------------------------
> commit a3ef974d30fd1adcf1a25940c2a2fa7e03fad6a0
> Author: Andrew Bartlett<abartlet at samba.org>
> Date:   Thu Feb 10 21:40:07 2011 +1100
>
>      s3-rpc_server Remove comment, yes the key is correct.
>
>      Autobuild-User: Andrew Bartlett<abartlet at samba.org>
>      Autobuild-Date: Mon Apr  4 13:31:52 CEST 2011 on sn-devel-104
>
> commit 77e67163daaa670ee43ddbc4fd3fd3e8c3c38d49
> Author: Andrew Bartlett<abartlet at samba.org>
> Date:   Thu Feb 10 21:04:01 2011 +1100
>
>      s3-auth consolidate create_local_token() into make_server_info_krb5()
>
>      This ensures that all callers don't need to each add builtin groups
>      and privileges to the user's token
>
>      Andrew Bartlett
>
> commit 841d0bc9e81dbe56352ac8b12e63e8257963936e
> Author: Andrew Bartlett<abartlet at samba.org>
> Date:   Mon Apr 4 19:18:47 2011 +1000
>
>      s3-selftest Remove more instances of /tmp in test_smbclient_s3.sh
>
> commit 6351dee4d810bfa20c3a892d0eba3b2ac828e193
> Author: Andrew Bartlett<abartlet at samba.org>
> Date:   Mon Apr 4 19:13:17 2011 +1000
>
>      s3-selftest Add testing of kerberos login
>
>      This uses a pre-calculated credentials cache, that should be valid
>      until 2036.
>
>      Andrew Bartlett
>
> commit 55134c9a9e4a47c6a8ed89ef10c95c0fa0d4daaf
> Author: Andrew Bartlett<abartlet at samba.org>
> Date:   Mon Apr 4 19:11:39 2011 +1000
>
>      s4-credentials Add a command line hook to set the kerberos credentials cache
>
>      This allows this to be specified independent of the KRB5CCNAME
>      environment variable (in this case, it's harder than it should be to
>      set up in the make test for s3 that way).
>
>      Andrew Bartlett
>
> commit ffb600330289e59071ffbbb071a7d20afb7ab09f
> Author: Andrew Bartlett<abartlet at samba.org>
> Date:   Mon Apr 4 09:22:03 2011 +1000
>
>      s3-selftest Disable log rotation in 'make test'
>
> -----------------------------------------------------------------------
>
> Summary of changes:
>   selftest/target/Samba3.pm                 |   66 +++++++++++++++++++++++++++++
>   source3/auth/proto.h                      |    4 +-
>   source3/auth/user_krb5.c                  |   12 +++++-
>   source3/rpc_server/dcesrv_gssapi.c        |    2 +-
>   source3/rpc_server/srv_pipe.c             |   12 -----
>   source3/script/tests/test_smbclient_s3.sh |    8 ++--
>   source3/selftest/ktest-krb5_ccache        |  Bin 0 ->  11966 bytes
>   source3/selftest/ktest-secrets.tdb        |  Bin 0 ->  45056 bytes
>   source3/selftest/tests.py                 |   19 +++++++--
>   source3/smbd/sesssetup.c                  |   20 +--------
>   source3/smbd/smb2_sesssetup.c             |   22 ++--------
>   source4/lib/cmdline/popt_credentials.c    |   14 ++++++-
>   12 files changed, 117 insertions(+), 62 deletions(-)
>   create mode 100644 source3/selftest/ktest-krb5_ccache
>   create mode 100644 source3/selftest/ktest-secrets.tdb


Wow, that is great stuff! Finally we have some security=ads testing on 
the buildfarm! the only problem is that the ktest tests fail quite 
often, I tried to nail down the problem using

SMBD_OPTIONS=-d10 make test TESTS=lookupsids FAIL_IMMEDIATELY=1 VALGRIND=1

but the failure seem not to happen when running under valgrind, do you 
have any other idea ? If we don't catch it, we should mark the kerberos 
tests knownfail for now probably.

Thanks.
Guenther

-- 
Günther Deschner                    GPG-ID: 8EE11688
Red Hat                         gdeschner at redhat.com
Samba Team                              gd at samba.org