Talloc: pool optimizations

Rusty Russell rusty at rustcorp.com.au
Mon Apr 4 00:25:03 MDT 2011


On Thu, 31 Mar 2011 20:17:38 +0200, "Stefan (metze) Metzmacher" <metze at samba.org> wrote:
> Hi,
> 
> using 2k from a 8k talloc stackframe seems to be bad.
> 
> I've coded some talloc_free and talloc_realloc optimizations
> which will try to reclaim unused memory from the talloc pool
> if it's the last chunk in the pool or if the pool is empty.
> 
> See
> http://gitweb.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/heads/master4-talloc
> 
> I need to add some more VALGRIND_MAKE_MEM_NOACCESS and
> talloc_fill logic, but the main code seems to work.

Looks like some nice cleanups, but do you have any benchmarks showing
the results?

Thanks,
Rusty.


More information about the samba-technical mailing list