samldb and associated patches
Matthias Dieter Wallnöfer
mdw at samba.org
Thu Sep 30 12:39:14 MDT 2010
Kamen Mazdrashki wrote:
> Hey Matthias,
> On Thu, Sep 30, 2010 at 09:53, Matthias Dieter Wallnöfer
> <mdw at samba.org <mailto:mdw at samba.org>> wrote:
> Hi Kamen & Andrew,
> Kamen Mazdrashki wrote:
> I think it looks good now.
> I am only little bit concerned about changes in made in
> But kcc_deleted is just a basic implementation anyway.
> well I really wanted to make it to see all deleted objects.
> yep, you are right. What I meant is that kcc_deleted() is going to
> apply now the same logic
> for all states of the object, and there may be a difference between
> and DeletedObject-Lifetime values. Anyway, your fix will allow us to
> have the chance
> for clean all kind of isDeleted objects, thanks :)
Yeah - I think you could look into this later - I really don't
understand much in this issue.
> Regarding "nTDSConnection" object -> kcc service creates them
> also. You may want to
> peek kcc implementation how it is done.
> I think that "Active Directory Sites and Services Manager" is
> also able to create
> Connection objects, but I am not sure how it does this.
> No, I speak from the "nTDSDSA" objects (NTDS Settings). The other
> ones you can create with any trouble, but you need the server and
> nTDSDSA object already there.
> I think this may be achieved with DsAddEntry() drs call?
That is possible
> But I think my tests should now be enough to test all interesting
> I still don't see a test for a subtree of objects with mixed
> systemFlags :)
> Anyway, I may implement such a test when I start implementing a test
> for DsAddEntry() (I think we still don't have a sane test for this
> entry point)
Well we could add afterwards one.
> So, Kamen & Andrew, if you like my work I hope that it will be
> merged soon.
> IMHO, it is ok to be pushed. I would suggest though for you to wait
> until the
> end of the week - so that guys at plugfest to get the chance to test only
> what related patches. What do you think?
Okay, I can wait until what you say me: Saturday, Sunday?
> Thanks a lot for your patience Matthias - I am not a fast reviewer,
> sorry for that!
> Oh, I have a patch for your problem with timeouts in FSMO test:
> Current timeout is about 20 secs and it should be quite enough, even
> for busy/slow machines.
Very appreciated, thanks.
More information about the samba-technical