[HEIMDAL] Incorrect 'dns search path' patch

Andrew Bartlett abartlet at samba.org
Wed Sep 29 12:33:55 MDT 2010


Love,

Thanks for keeping an eye on the patches we are putting into Samba4.  I
was going to wait until the end of the week, and we are sure that we are
sure these are the final form, but anyway...

My concern is that this:
http://github.com/heimdal/heimdal/commit/f454f45fbfa1172ebc3632a1d89f28cbbdbc0bff

Is not sufficient - that form broke our 'make test' badly, as it does
not handle IP addresses that are encoded in IPv6 form - with : not dots
- they are then invalid and getaddrinfo fails.  You also need:

http://gitweb.samba.org/?p=samba.git;a=commitdiff;h=4be269664451f3df82a8b4939ffcf5d4274d02ed

We tried this simple patch first, and regretted it :-)

Andrew Bartlett
-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Cisco Inc.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20100930/a6fa7ad7/attachment.pgp>


More information about the samba-technical mailing list