[PATCH] Libnet vampire for Schema refactored to perform multi-pass Schema resolving

Kamen Mazdrashki kamenim at samba.org
Mon Sep 27 02:44:50 MDT 2010


On Mon, Sep 27, 2010 at 05:04, Andrew Bartlett <abartlet at samba.org> wrote:

> On Sat, 2010-09-25 at 13:36 +0300, Kamen Mazdrashki wrote:
> > Hi Andrew,
> >
> >
> > Here is a version with approach that doesn't need memmoving objects
> > back and forth.
> >
> http://git.samba.org/?p=kamenim/samba.git;a=shortlog;h=refs/heads/master-push
> > Please push if you are happy with it.
> >
> >
> > The only thing I'm worried is that it is isn't clear as 'memmove()'
> > approach.
> > As I said, 'memmove()' approach is all around Samba and people are
> > used to it :)
>
> I've reworked this at
>
> http://git.samba.org/?p=abartlet/samba.git/.git;a=shortlog;h=refs/heads/kamenim-schema-convert
>
> I much prefer the handling of this as a linked list.  What do you think?
>
> It's essentially the same with same concerns I've had about linked list
usage
a week ago -> added cost of a lot more memory allocations and more
memory consumed.
(as far as I recall, the whole discussion started because of performance
concerns)
Anyway, it seems it work fine, so I am happy with it ;)

-- 
CU,
Kamen


More information about the samba-technical mailing list