samldb and associated patches
Matthias Dieter Wallnöfer
mdw at samba.org
Mon Sep 20 01:36:13 MDT 2010
the commit specifications were thought to be commit to the preceeding
one from the commit of the next item (Starting from the bottom to the head).
I was mainly interested if you could take a slight look (especially the
delete patches) to say me if you are comfortable with these.
Andrew Bartlett wrote:
> On Sun, 2010-09-19 at 22:58 +0200, Matthias Dieter Wallnöfer wrote:
>> Hi Andrew,
>> I've reworked the patchset:
>> * Patches until 196e1dfcfece636054a224cc5bd2904704671530 should work
>> without problems (cosmetics and some enhancements to the SAMLDB
>> primary group detection)
>> * Patches until aca7270d7fc478385a933c81c3b1cc5d14e8da79 should also
>> work (makes the most of the rootDSE attributes dynamic - I had to
>> leave "dsServiceName" static for now since otherwise s4 stops working)
>> * The patches afterwards fixes the delete operation. I found out
>> that beginning with DC functional level>= 2008_R2 we need to make
>> use of the SHOW_RECYCLED and not SHOW_DELETED control to find
>> always all entries. Since otherwise recycled objects aren't
>> handled. These patches try to fix this - would be nice if you
>> could take a look if my thoughts are right.
>> It would be nice if you could start applying at least some parts. But
>> probably a "make test" is still useful.
> I'm rather confused as to exactly what commits you have prepared that
> are a tested and cohesive set. Can you prepare me a tree, which passes
> 'make test' that you want to me to merge?
> Once you let me know exactly which of these patches you want merged, and
> which pass 'make test', I can look at it.
> Andrew Bartlett
More information about the samba-technical