samldb and associated patches

Matthias Dieter Wallnöfer mdw at samba.org
Sat Sep 18 03:21:24 MDT 2010


Andrew,

Andrew Bartlett wrote:
> On Sat, 2010-09-18 at 09:14 +0200, Matthias Dieter Wallnöfer wrote:
>    
>>> lookup without the...
>>> http://gitweb.samba.org/samba.git/?p=mdw/samba.git;a=commitdiff;h=9f7826fcd38267e103181bbb54539eb73db13718
>>>
>>> This seems to do a unindexed search on dnsHostName.  We should avoid
>>> unindexed searches in routines such as this - and I fear that soon
>>> someone will request that likewise dnsHostName be made dynamic.  Perhaps
>>> instead search for our samAccountName based on the lp_netbios_name(),
>>> and follow the serverReference link?
>>>
>>>        
>> Well, so I could make "dNSHostName" dynamic just now. And I will use
>> "sAMAccountName".
>>      
This seems easier as it is. In fact the lp_ctx isn't always the one from 
the server but could also be provided by the client (consider 
"torture_netlogon" tests). And then we end in "NTDS settings container 
not found" and failing tests.

Matthias



More information about the samba-technical mailing list