samba changing mode of files on rename

[Jeff Layton]

I recently noticed a regression in samba in the last few weeks. Here's
a simple way to reproduce it:

1) use smbclient to put a file on a samba share
2) change the mode of the file to something without the owner execute bit set
3) rename the file using smbclient

When you do this, the newly renamed file will magically end up with the
owner execute bit set. It seems like samba ought not be changing the
mode of files when renaming them so I consider this a regression.

I've reported the bug in the Fedora BTS, and attached some info there.
Anyone more familiar with this code willing to have a look?

    https://bugzilla.redhat.com/show_bug.cgi?id=617771

I've was able to reproduce it today using the most recent samba version
available in the Fedora repos (3.5.5).

Thanks,
-- 
Jeff Layton <jlayton at samba.org>