commit 25a2d94974c7befd13f90e52b61e297c31ae52e9

Björn JACKE bj at SerNet.DE
Wed Sep 15 08:41:32 MDT 2010


Hi Simo,

from 25a2d94974c7befd13f90e52b61e297c31ae52e9
        } else {
                /* last_refresh newer than now, wow, someone just updated the
                 * cache under our nose, do not do again. */
                return false;

doesn't this result in a cache that never gets updated for a very long time if
the clock was e.g. accidently being set a year in the future and being
corrected then?

The best would be to make the cache non-persistent (if it iѕn't already...)
and use time_mono() instead of time(). This makeѕ things it keep working even
if the clock is being set back or forth.

Cheers
Björn
-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen


More information about the samba-technical mailing list