privileges patches

tridge at tridge at
Fri Sep 3 18:06:19 MDT 2010

Hi Michael and Volker,

I've reviewed Andrew's session-info branch (which has the privileges
changes), and I'm now happy with it after asking for a few tidyups and
minor bug fixes, including adding backwards compatibility support for
the existing s3 privileges database format. I've signed off on the

I think it is a very nice consolidation of the privileges code, and it
achieves an important milestone of making the security_token structure
in common between Samba3 and Samba4. That will make it much easier to
share a large range of authentication related code.

So I'd like it to be merged into master, but as you have both raised
concerns I'd like to check with you first. 

I understand that you like the SE_PRIV structure, but I think if you
look at the final result of the patch you'll see that it really is an
improvement in readability as the old code was rather obscure. For
example, look at is_any_privilege_assigned() from the old code, which
does some pretty obscure bit manipulations.

So do you object to Andrew pushing this into master?

Cheers, Tridge

More information about the samba-technical mailing list