[patch 1/2] cifs: add kfree() on error path

Dan Carpenter error27 at gmail.com
Wed Oct 27 15:19:32 MDT 2010


We leak 256 bytes here on this error path. 

Signed-off-by: Dan Carpenter <error27 at gmail.com>

diff --git a/fs/cifs/file.c b/fs/cifs/file.c
index 45af003..06a006b 100644
--- a/fs/cifs/file.c
+++ b/fs/cifs/file.c
@@ -1353,6 +1353,7 @@ static int cifs_writepages(struct address_space *mapping,
 	if (!experimEnabled && tcon->ses->server->secMode &
 			(SECMODE_SIGN_REQUIRED | SECMODE_SIGN_ENABLED)) {
 		cifsFileInfo_put(open_file);
+		kfree(iov);
 		return generic_writepages(mapping, wbc);
 	}
 	cifsFileInfo_put(open_file);


More information about the samba-technical mailing list