s4:dsdb - remove some calls of "samdb_msg_add_string" when we have talloc'ed strings

Andrew Bartlett abartlet at samba.org
Sun Oct 24 15:10:07 MDT 2010


On Sun, 2010-10-24 at 22:43 +0200, Matthias Dieter Wallnöfer wrote:
> Andrew,
> 
> well, the idea would be to start going away from "samdb_msg_add_string" 
> and use "ldb_msg_add_string" or "ldb_msg_add_steal_string" (from the LDB 
> api). We need to reduce these redundant functions. Well here it's a bit 
> different - since "samdb_msg_add_string" always "talloc_strdup"'s and 
> "ldb_msg_add_string" doesn't.

Indeed. 

Anyway, I was mostly wanting to ensure you knew about
ldb_msg_add_steal_string()

Thanks for all the work you are putting into this!

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Cisco Inc.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20101025/f24c1a96/attachment.pgp>


More information about the samba-technical mailing list