s4: Patch proposal for making minimal includes script work again

Andrew Bartlett abartlet at samba.org
Mon Oct 18 16:29:31 MDT 2010

On Mon, 2010-10-18 at 14:35 +0200, Matthias Dieter Wallnöfer wrote:
> Hi tridge & abartlet,
> here a small patch proposal to make the useful minimal includes script 
> work again. It's far from complete (I didn't manage to get it working) 
> but probably a start on fixing it.
> http://gitweb.samba.org/samba.git/?p=mdw/samba.git;a=commitdiff;h=35f83f2eb486b7c0ee37d323daf6d282d48bb5b3

Is there any reason to do this via the make wrapper?  I certainly would
be hesitant about 'make -j'.

In any case, can you please ensure you run *every* patch you generate
with this script past the list for an explicit ack (including by the
maintainer of the area, if there is one by the maintainers file or team
convention), before you commit them to the tree?  

The results from this script can be very useful, when it works, but they
can also be very misleading, or choose a working, but incorrect answer.

For example, it may select a header set that compiles, but which then
causes us not to compile in a whole file (because the file is under a
#define that no longer exits).  

Similarly, it may select a header combination that works, but only
because another header includes a IDL generated file for it's own use,
or because #includes.h includes this header, but we are trying to remove
it from there. 

Be extra careful in common code, as there are 3 different build systems
in use (s4-waf, s3-waf, s3-make). 

This isn't a tool you can just 'follow the warnings' on, and if you
remember how much trouble we had with signed->unsigned conversions for
something that is 'obviously correct' (they are not always), this is
much much less obvious as to what the correct answer is, and requires
proper diligence about every single instance.  

Please do not submit 'mass' patches to fix these 'issues'.  Take them
carefully, one at a time. 

Andrew Bartlett

Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Cisco Inc.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20101019/92ab0bf0/attachment.pgp>

More information about the samba-technical mailing list