[PATCH] pidl-Python: Fix code generated for WERROR type
jelmer at samba.org
Sun Oct 17 19:41:40 MDT 2010
On Fri, 2010-10-08 at 22:23 +0300, Kamen Mazdrashki wrote:
> On Fri, Oct 8, 2010 at 17:07, Jelmer Vernooij <jelmer at samba.org>
> Hi Kamen,
> On Fri, 2010-10-08 at 04:27 +0300, Kamen Mazdrashki wrote:
> > What do you think about last 3 commits in my wip branch:
> For the last patch, I think we should be unlinking from
> not NULL, otherwise we end up leaking memory. Thanks for
> fixing that
> btw. Ideally we should also be checking the return value of
> talloc_unlink(), although I'm not really sure what the right
> thing to do
> is when it returns failure.
> I don't quite agree with this :). obj->talloc_ctx is always allocated
> in NULL
> context. So, to my understanding, we should unlink it from its initial
> (null_context) when we deallocate py_object which happens to have
> pending references.
> Am I missing something?
No, you're not missing anything, I am. :-) Please push this particular
patch. Can you add an SMB_ASSERT() to make sure talloc_unlink()
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 836 bytes
Desc: This is a digitally signed message part
More information about the samba-technical