Review request

[Matthias Dieter Wallnöfer]

I've written to MS and CCed you.

Hope you are comfortable with it. Regarding the "samldb2" patches? Are 
you fine if I merge them?

Greets,
Matthias

Andrew Bartlett wrote:
> On Mon, 2010-10-11 at 17:13 +0300, Kamen Mazdrashki wrote:
>    
>> Matthias,
>>
>> Sorry for asking but, as long as I read the code,
>> you are replacing a code that returns some string, with code
>> that returns empty string (but now with a FIXME comment).
>> Both implementation are incorrect as long as I understood.
>> So my question is ->  what is the benefit from this change?
>>
>> An if my understanding is correct, then I should suggest you
>> to implement a test that reveals what the real behavior should be.
>> This test will fail and thus remind us we have something to do.
>> What I see now is masking the problem with another problem
>> with a FIXME comment :)
>>      
> I agree.
>
>    
>> On Mon, Oct 11, 2010 at 16:06, Matthias Dieter Wallnöfer
>> <mdw at samba.org>wrote:
>>
>>      
>>> Andrew,
>>>
>>> and is MS-SAMR 2.2.4.1 to vague for you?
>>>
>>>        
>>>> ReplicaSourceNodeName: A counted Unicode string of type
>>>>          
>> RPC_UNICODE_STRING
>>      
>>>> that
>>>> represents a replication partner.
>>>>
>>>>          
> Yes, I think this is vauge.  Which replication partner does it
> represent?  How is it selected?
>
> I think we should have more information and proof before changing
> working code into a TODO.
>
> Andrew Bartlett
>
>