[PATCH] subunithelper: Don't access 'message' attribute directly as it deprecated
kamenim at samba.org
Sun Oct 10 18:36:49 MDT 2010
Thanks for applying this!
And made it look like I knew what I am doing :)
On Sun, Oct 10, 2010 at 04:05, Jelmer Vernooij <jelmer at samba.org> wrote:
> Hi Kamen,
> On Sun, 2010-10-10 at 03:21 +0300, Kamen Mazdrashki wrote:
> > Would you please consider applying one of the attached patches?
> > It is intended to stop "Exception.message is deprecated" warning.
> > I prefer the 0001- one, as our subclasses of Exception are just
> > a String exceptions and using repr() would give more clues about
> > what/where has failed.
> Thanks for the patches.
> The first isn't really an option - this exception is only created in one
> location so repr() doesn't show any useful extra information. Secondly,
> every time we filter the subunit stream we would add this information
> again, which doesn't seem very useful.
> I'll apply something similar to the second one - we also need to cope
> with encoding.
More information about the samba-technical