[PATCH] subunithelper: Don't access 'message' attribute directly as it deprecated

Jelmer Vernooij jelmer at samba.org
Sat Oct 9 19:05:27 MDT 2010

Hi Kamen,

On Sun, 2010-10-10 at 03:21 +0300, Kamen Mazdrashki wrote:
> Would you please consider applying one of the attached patches?
> It is intended to stop "Exception.message is deprecated" warning.
> I prefer the 0001- one, as our subclasses of Exception are just
> a String exceptions and using repr() would give more clues about
> what/where has failed.
Thanks for the patches.

The first isn't really an option - this exception is only created in one
location so repr() doesn't show any useful extra information. Secondly,
every time we filter the subunit stream we would add this information
again, which doesn't seem very useful.

I'll apply something similar to the second one - we also need to cope
with encoding.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20101010/190241ae/attachment.pgp>

More information about the samba-technical mailing list