[PATCH] pidl-Python: Fix code generated for WERROR type

Jelmer Vernooij jelmer at samba.org
Fri Oct 8 08:07:02 MDT 2010

Hi Kamen,

On Fri, 2010-10-08 at 04:27 +0300, Kamen Mazdrashki wrote: 
> What do you think about last 3 commits in my wip branch:
> http://git.samba.org/?p=kamenim/samba.git;a=shortlog;h=refs/heads/pylint-fix-build

For the last patch, I think we should be unlinking from obj->talloc_ctx
not NULL, otherwise we end up leaking memory. Thanks for fixing that
btw. Ideally we should also be checking the return value of
talloc_unlink(), although I'm not really sure what the right thing to do
is when it returns failure.

+1 on the warning fix.

I don't see the need for the third patch. The caller shouldn't pass in
tuples where an error is expected. WERRORs are only 32 bits so int
objects should be sufficient there. 

Can you give a bit more background as to why you need that third patch?


-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20101008/4dcef86a/attachment.pgp>

More information about the samba-technical mailing list