fix tevent select style?

Stefan (metze) Metzmacher metze at samba.org
Thu Oct 7 04:34:23 MDT 2010


Hi Volker,

> On Wed, Oct 06, 2010 at 11:05:12AM -0700, Jeremy Allison wrote:
>> Ooooh. That's a really nice, subtle fix ! Well caught.
>>
>> Only fix is change "uncontionally" -> "unconditionally" :-).
>>
>> Please push !
> 
> Let's wait for the tevent maintainers to wake up.

As a short term fix that patch is fine.

However the real fix would be to just use one fd event per fd,
as epoll doesn't allow more than one event per fd.

That's why the s3 libsmb code will always trigger the
fallback to select codepath.

metze

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 262 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20101007/1e7e1b6a/attachment.pgp>


More information about the samba-technical mailing list