[PATCH] s4:netcmd/drs.py - use "objectClass" for discovering the server and it's NTDS settings object

Kamen Mazdrashki kamenim at samba.org
Sun Nov 28 06:44:28 MST 2010


Let me see if understood you correctly here:
you are "optimizing" a filters that are:
  - used by windows tools, perhaps for a good reason
  - this code has been tested and used for almost a year now
And you are asking me, to test your changes to check if something is broken :)

I think it is just the opposite - you should check that this works in
all possible
cases. This is a client code that is supposed to just work.

P.S. Now I see you've just reverted it. Thanks!


On Sun, Nov 28, 2010 at 12:40, Matthias Dieter Wallnöfer <mdw at samba.org> wrote:
> Kamen,
> are you speaking about the "(objectClass=nTDSDSA)" filter? I'm pretty sure
> that this is working since we are using this also on other locations of our
> C code. As soon as you find that something is broken please immediatly
> inform me and we will fix all that code places in one operation.
> Greets,
> Matthias
> Kamen Mazdrashki wrote:
>> Hi Matthias,
>> I am pretty sure I've got those filters while sniffing win-to-win
>> communication.
>> Please, make sure your optimization works with all Windows versions.

More information about the samba-technical mailing list