Move prefixmap to one or two files?
kamenim at samba.org
Thu Nov 25 14:41:20 MST 2010
For some reason, I haven't noticed you mail till now!
On Thu, Nov 25, 2010 at 04:54, Andrew Bartlett <abartlet at samba.org> wrote:
> I was looking at making some changes to the prefixMap code, in
> particular I would like to change it to use dsdb_module_modify() so that
> we don't walk over the module stack twice, and don't need to use
> Anyway, in doing this, I noticed that the prefixmap code is mixed in
> with the schema_init.c code, aside from your new schema_prefixmap.c
> I wonder if we should move all the functions to schema_prefixmap.c, or
> create another file for the ldb-related prefixmap manipulations?
> What do you think?
When I start prefixMap separation, I havent' moved all related code into
dsdb_prefixmap.c as I was tired of reviews :)
So I just stuck to code I needed to implement prefixMap marshaling properly.
Personally I prefer all code related to an object impelementation to be located
in a single spot. However I don't think prefixMap serialization to/from ldb is
part of prefixMap class implementation and I think it would be great
to be moved
in a separate file - just like you and Tridge did for schemaInfo implementation.
I think there is ldb-related functionality in dsdb_prefixmap.c too.
More information about the samba-technical