s4: adding a DsdbTestCase class
Matthias Dieter Wallnöfer
mdw at samba.org
Fri Nov 19 11:58:13 MST 2010
This is a big step forward which helps to remove redundancies. Please
apply these changes!
Nadezhda Ivanova wrote:
> Hi Jelmer and team,
> In the testsuites in dsdb/tests there is a practise currently that each test
> suite defines its own methods, even if they are the same as the ones used in
> other testsuites, such as delete_force, get_domain_sid and a few others. To
> avoid this, I suggest adding a DsdbTestCase class to samba.tests that
> contains these methods, and all the testsuites that use them to inherit it,
> as is the case with BlackboxTestCase and others. I have added the class
> And here is what acl and sec_descriptor look like now.
> If it is OK with everyone, I would like to push this to master and change
> the other testsuites in dsdb/tests to inherit DsdbTestCase too.
More information about the samba-technical