[s4] Crash in netr_LogonGetDomainInfo

Stefan (metze) Metzmacher metze at samba.org
Fri Nov 19 02:21:24 MST 2010


Am 19.11.2010 10:07, schrieb Andrew Bartlett:
> On Fri, 2010-11-19 at 09:42 +0100, Matthias Dieter Wallnöfer wrote:
>> Reworked version.
> 
> That addresses my concerns.  My final request would be to use names
> other than temp_str and temp_str2 to make the code a little easier to
> follow.  Also, extra torture tests would be great, to ensure we don't
> forget about the possible NULL de-reference in future. 
> 
> Anyway, I look forward to seeing this in the tree!  

Thanks!

So we should not delete an existing dnsHostName attribute,
if the clients sends NULL?

metze

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 262 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20101119/c9219903/attachment.pgp>


More information about the samba-technical mailing list